mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <neil.con...@gmail.com>
Subject Review Request 42265: Fixed more tests that didn't set a shutdown expect for MockExecutor.
Date Wed, 13 Jan 2016 21:24:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42265/
-----------------------------------------------------------

Review request for mesos, Joris Van Remoortere and Timothy Chen.


Bugs: MESOS-4349
    https://issues.apache.org/jira/browse/MESOS-4349


Repository: mesos


Description
-------

Specifically, the following tests:

MasterTest.OfferNotRescindedOnceUsed
OversubscriptionTest.FetchResourceUsageFromMonitor
OversubscriptionTest.QoSFetchResourceUsageFromMonitor
SlaveTest.ContainerUpdatedBeforeTaskReachesExecutor


Diffs
-----

  src/tests/master_tests.cpp 223b9d20a3a8a8194a3a6a605ec2394c37ab5957 
  src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a 
  src/tests/slave_tests.cpp eb47b5319b16601b8600c4d53035b8337382070c 

Diff: https://reviews.apache.org/r/42265/diff/


Testing
-------

Ran each test a few hundred times with and without the changes; without the changes, a warning
is observed. With the changes, no warning is observed.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message