mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <neil.con...@gmail.com>
Subject Re: Review Request 41806: Cleaned up assertions in test cases around JSON HTTP responses.
Date Wed, 13 Jan 2016 19:19:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41806/
-----------------------------------------------------------

(Updated Jan. 13, 2016, 7:19 p.m.)


Review request for mesos and Adam B.


Changes
-------

Address review comments, make a few other minor cleanups.


Repository: mesos


Description
-------

Used `AWAIT_EXPECT_RESPONSE_HEADER_EQ()` to check the "Content-Type" of
the response, rather than accessing the "headers" field directly, and
used the symbol `APPLICATION_JSON` rather than a string literal. Also
added "Content-Type" checks to a few places that had neglected to make
them, and cleaned up some whitespace style.


Diffs (updated)
-----

  src/tests/executor_http_api_tests.cpp 952aacb720715ad26f91fa08bc386b242b7e007b 
  src/tests/fault_tolerance_tests.cpp fd1c3c90101eed9ef9352511e0c72a463cca965c 
  src/tests/master_tests.cpp 223b9d20a3a8a8194a3a6a605ec2394c37ab5957 
  src/tests/metrics_tests.cpp f081fb9b68f25c6d6005f195c34253fba8abc146 
  src/tests/monitor_tests.cpp a848d14ebb6cab79c06bcf55bd39f044b41a006e 
  src/tests/repair_tests.cpp 63ec889c4954c2c60d3466952551aa25b3284ddf 
  src/tests/scheduler_driver_tests.cpp 1365d21ccad87923b862fb4942f1fd51630a62b7 
  src/tests/scheduler_http_api_tests.cpp 4d23a5a8368e0ed126469fa4a90a889b339ad004 
  src/tests/slave_tests.cpp eb47b5319b16601b8600c4d53035b8337382070c 
  src/tests/status_update_manager_tests.cpp bd34b97a3559a5fea9a7a253a89e0ac3029f4a33 
  src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b 

Diff: https://reviews.apache.org/r/41806/diff/


Testing
-------

make check


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message