mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avinash sridharan" <avin...@mesosphere.io>
Subject Re: Review Request 42098: Added unit test-case for CgroupsNetClsIsolatorProcess.
Date Wed, 13 Jan 2016 17:51:16 GMT


> On Jan. 12, 2016, 10:28 p.m., Joseph Wu wrote:
> > src/tests/containerizer/isolator_tests.cpp, line 912
> > <https://reviews.apache.org/r/42098/diff/1/?file=1193883#file1193883line912>
> >
> >     Is there a more meaningful check you can do here?
> >     
> >     Like a `strings::contains(...)` where you check for some Mesos-related string?

To make the test stronger, now tokenizing the output and verifying that we are getting only
numbers in the output. Hopefully this gives us more confidence that we are seeing the PIDs
added to the cgroup.


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42098/#review114041
-----------------------------------------------------------


On Jan. 13, 2016, 3:07 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42098/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 3:07 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit test-case for CgroupsNetClsIsolatorProcess.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/isolator_tests.cpp 91178b69ccbf5b6cbf64421e5602e6d554fc34ca

> 
> Diff: https://reviews.apache.org/r/42098/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message