mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 35711: Disallow special characters in role name.
Date Wed, 13 Jan 2016 17:12:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/
-----------------------------------------------------------

(Updated Jan. 13, 2016, 5:12 p.m.)


Review request for mesos, Adam B, Jie Yu, and Michael Park.


Changes
-------

Address @klaus1982 and @adam-mesos comments.


Bugs: MESOS-2210
    https://issues.apache.org/jira/browse/MESOS-2210


Repository: mesos


Description
-------

Disallow special characters in role name.


Diffs (updated)
-----

  docs/roles.md af1adad7ec8122fd10f7de44848014b850416bcd 
  include/mesos/roles.hpp PRE-CREATION 
  src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660 
  src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 
  src/common/roles.cpp PRE-CREATION 
  src/master/master.cpp c122c30d943813fc3ce9e7025783c7231809b022 
  src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 
  src/tests/role_tests.cpp 373ae267b85588fe491ab0a0ce8aa195f971aac3 

Diff: https://reviews.apache.org/r/35711/diff/


Testing
-------

make -j8 check


Thanks,

haosdent huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message