mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 42194: WIP: Handle unreserve logic for dynamic reservation (3/3).
Date Wed, 13 Jan 2016 11:25:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42194/#review114181
-----------------------------------------------------------


Bad patch!

Reviews applied: [40375, 41334, 41333, 40529, 41772, 40339, 40632]

Failed command: ./support/apply-review.sh -n -r 40632

Error:
 2016-01-13 11:25:26 URL:https://reviews.apache.org/r/40632/diff/raw/ [14855/14855] ->
"40632.patch" [1]
error: patch failed: src/master/allocator/mesos/hierarchical.cpp:434
error: src/master/allocator/mesos/hierarchical.cpp: patch does not apply

- Mesos ReviewBot


On Jan. 13, 2016, 9:58 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42194/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 9:58 a.m.)
> 
> 
> Review request for mesos and Klaus Ma.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Handle unreserve logic for dynamic reservation with allocation slack.
> 
> This patch is halding the case when using updateAvailable to unreserve
> some resources.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f

>   src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59

> 
> Diff: https://reviews.apache.org/r/42194/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message