mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bannier" <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 41882: Constrained types used in Flags instantiation.
Date Wed, 13 Jan 2016 10:43:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41882/
-----------------------------------------------------------

(Updated Jan. 13, 2016, 11:43 a.m.)


Review request for mesos, Benjamin Hindman and Till Toenshoff.


Changes
-------

Used an improved impl (that e.g., is less repetitive).


Bugs: MESOS-4278
    https://issues.apache.org/jira/browse/MESOS-4278


Repository: mesos


Description (updated)
-------

To make the implementation less repetitive reimplemented `FlagsBase`
with a variadic template; this allows to now use an arbitrary number of
`FlagsBase` bases.

Since `Flags<>` does already inherit virtually from `FlagsBase` it
should be a safer base class than `FlagsBase` for users.

Review: https://reviews.apache.org/r/41882/


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp addef78ddeb0007cf1e1c79738381138a18a35b6


Diff: https://reviews.apache.org/r/41882/diff/


Testing
-------


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message