mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Klues" <klue...@gmail.com>
Subject Re: Review Request 41243: Updated how we find the .git directory in bootstrap.
Date Wed, 13 Jan 2016 10:34:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41243/
-----------------------------------------------------------

(Updated Jan. 13, 2016, 10:34 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, Till Toenshoff,
and Vinod Kone.


Changes
-------

Reverted back to using the sh implementation of relPath rather than the python one.


Bugs: MESOS-4125
    https://issues.apache.org/jira/browse/MESOS-4125


Repository: mesos


Description
-------

When building from git, bootstrap will (among other things) install
pre-commit and post-rewrite hooks into the .git/hooks directory of the
mesos tree. However the current implementation always assumes that .git
exists in the same directory as the bootstrap file. This may not always
be true.

Most notably, it is not true if the mesos tree is included as a
submodule inside another project. When included as a submodule, .git is
no longer a directory, but rather a file whose text contains a pointer
back to the actual location of the .git folder inside the containing
project. To get at this directory, we need to run 'git rev-parse
--git-common-dir' instead of simply assuming that the local .git is the
proper directory.

Review: https://reviews.apache.org/r/41243


Diffs (updated)
-----

  bootstrap ea71ff22e42bf5e224483508d91c33ddfd350f52 

Diff: https://reviews.apache.org/r/41243/diff/


Testing
-------

Tested on native Mac OS X El Capitan
Tested on vagrant boxes for bento/centos-7.1, ubuntu/trusty64, and https://github.com/tommy-muehle/puppet-vagrant-boxes/releases/download/1.0.0/centos-6.6-x86_64.box
Also tested on docker image centos:7


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message