mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 42164: Allowed (un)reserve operations without a principal.
Date Wed, 13 Jan 2016 05:06:08 GMT


> On 一月 13, 2016, 2:56 a.m., Guangya Liu wrote:
> > src/tests/master_validation_tests.cpp, lines 368-381
> > <https://reviews.apache.org/r/42164/diff/6/?file=1195184#file1195184line368>
> >
> >     Sorry, I should have propsed my comments in one review. Seems we need validate
both reserve and unreserve without a principal.
> 
> Greg Mann wrote:
>     That's OK, I thought about including such a test for the unreserve operation and
I decided it wasn't worth it since we're not actually testing anything about the principal
in the unreserve validation function. In the subsequent patch, I remove the `hasPrincipal`
parameter, and we don't check anything about the principal in the resource's `ReservationInfo`,
so it wasn't clear to me what exactly we would be verifying with such a test.
>     
>     What do you think?

Got it, agree that we can ignore this.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42164/#review114140
-----------------------------------------------------------


On 一月 13, 2016, 2:45 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42164/
> -----------------------------------------------------------
> 
> (Updated 一月 13, 2016, 2:45 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-3940
>     https://issues.apache.org/jira/browse/MESOS-3940
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allowed (un)reserve operations without a principal.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305 
>   src/tests/master_validation_tests.cpp fbf8fadbc04a7cbc60ee6091e0224339389b400f 
>   src/tests/reservation_endpoints_tests.cpp b8edd6fafedd4c2221a8d19c1ebc71254071a8c7

> 
> Diff: https://reviews.apache.org/r/42164/diff/
> 
> 
> Testing
> -------
> 
> Two master validation tests were removed which tested to make sure that reserve and unreserve
operations would not succeed without a principal.
> 
> `make check` was used to test on both OSX and Ubuntu 14.04
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message