mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Mann" <g...@mesosphere.io>
Subject Re: Review Request 42215: Added expectations for call to mocked executor shutdown.
Date Wed, 13 Jan 2016 00:05:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42215/
-----------------------------------------------------------

(Updated Jan. 13, 2016, 12:05 a.m.)


Review request for mesos, Neil Conway and Timothy Chen.


Bugs: MESOS-4347
    https://issues.apache.org/jira/browse/MESOS-4347


Repository: mesos


Description
-------

Added expectations for call to mocked executor shutdown. The mock executor's shutdown method
sometimes gets executed before the test exits, so it should be explicitly expected.


Diffs
-----

  src/tests/reservation_tests.cpp 61d275c47fbb02baf22e4ad8f9b1580886da51d9 

Diff: https://reviews.apache.org/r/42215/diff/


Testing
-------

I used `GTEST_FILTER="ReservationTest.*" bin/mesos-tests.sh --gtest_repeat=10000 --gtest_break_on_failure=1
| grep -B 3 -A 6 WARNING` to reproduce the warnings, and then to verify that they were gone
after the fix. Note that when running this command after the patch, other warning may be seen
due to https://issues.apache.org/jira/browse/MESOS-4350


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message