mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Klues" <klue...@gmail.com>
Subject Re: Review Request 42212: Added unit test for framework/task history flags.
Date Tue, 12 Jan 2016 22:12:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42212/
-----------------------------------------------------------

(Updated Jan. 12, 2016, 10:12 p.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-3307
    https://issues.apache.org/jira/browse/MESOS-3307


Repository: mesos


Description
-------

This commit adds a unit test to verify that the the max_frameworks and
max_tasks_per_frameworks flags for master work properly. Specifically,
we test to verify that the proper amount of history is maintained for
both 0 values to these flags as well as positive values <= to the total
number frameworks and tasks per framework actually launched.


Diffs
-----

  src/tests/master_tests.cpp 223b9d20a3a8a8194a3a6a605ec2394c37ab5957 

Diff: https://reviews.apache.org/r/42212/diff/


Testing (updated)
-------

This is a unit test.  I ran it on my mac and on ubuntu 14.04.

GTEST_FILTER="MasterTest.FrameworksTasksCompletedFlags" make check -j 7


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message