mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 41938: Cleaned up quota tests.
Date Tue, 12 Jan 2016 21:33:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41938/
-----------------------------------------------------------

(Updated Jan. 12, 2016, 9:33 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.


Changes
-------

Rebased; addressed Jörg's issues.


Repository: mesos


Description
-------

Changes made:
  - removed extra ';' in resources string;
  - renamed variables for clarity;
  - updated comments;
  - removed explicit conversion to `Resources`;
  - wrapped test cases in {} blocks.


Diffs (updated)
-----

  src/tests/master_quota_tests.cpp 776a168254af6fa8a5d87d4580b35d83f2d5909a 
  src/tests/registrar_tests.cpp 6064621a001d66423f9b2dc7b749b67d9fc4bc13 

Diff: https://reviews.apache.org/r/41938/diff/


Testing
-------

`make check` on Mac OS 10.10.5


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message