mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilbert Song" <songzihao1...@gmail.com>
Subject Re: Review Request 42058: Fixed stout protobuf::parse by passing error message in nested JSON.
Date Mon, 11 Jan 2016 23:39:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42058/
-----------------------------------------------------------

(Updated Jan. 11, 2016, 3:39 p.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, Joseph
Wu, and Timothy Chen.


Bugs: MESOS-4311
    https://issues.apache.org/jira/browse/MESOS-4311


Repository: mesos


Description
-------

Fixed stout protobuf::parse by passing error message in nested JSON.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp bf2a2b8a9f67c6a4cf66b156b9c14fae015a8af0


Diff: https://reviews.apache.org/r/42058/diff/


Testing
-------

make check (ubuntu14.04 + clang-3.6)

Because this patch depends on patch `41943`'s fix in `include/stout/protobuf.hpp`. To avoid
compiling `protobuf_tests.proto` on different branches and merge them, this patch is implemented
depending on `41943`. I did the following test:

1. Reverted any changes in `include/stout/protobuf.hpp`.
2. Tested the `ParseNestedJSONContainingJSONNull` test case -> failed (either not passing
any nested error message or passing a wrong message).
3. Changed `include/stout/protobuf.hpp` on the part of passing nested error messages ->
expected failures with correct error messaged showed.
4. Re-add the `include/stout/protobuf.hpp` fix from patch `41943` -> passed.


Thanks,

Gilbert Song


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message