mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 42040: Added Quota Operator Documentation.
Date Mon, 11 Jan 2016 18:47:58 GMT


> On Jan. 7, 2016, 11:55 p.m., Neil Conway wrote:
> > docs/quota.md, line 21
> > <https://reviews.apache.org/r/42040/diff/1/?file=1186512#file1186512line21>
> >
> >     Is the analogy between quota and dynamic reservation accurate/helpful? A dynamic
reservation reserves _particular_ resources on a _specific_ agent, and the reservation fails
if the resources are unavailable; quota just ensures that _sufficient_ resources in one or
more agents are dedicated for the role. Calling quota a "cluster-wide dynamic reservation"
doesn't capture this, IMO.
> 
> Alexander Rukletsov wrote:
>     A dynamic reservation does not reserve a _particular_ resource. The difference between
reserving on a specific agent and anywhere in the cluster is captured by "cluster-wide". You
are right that a dynamic reservation fails if there are not enough resources, but same does
quota due to the capacity heuristic check.
>     
>     The reason we decided to add this sentence is to give operators better understanding
what this new feature is about using analogy with things they are already familiar with. However,
if folks think the analogy is more misleading than helpful, we can remove this sentence.
>     
>     I personally prefer being slightly imprecise but give the big picture and intuition.
I remember a poster in the Institute for Nuclear Research in Dubna, here is my translation:
"One should explain a scientific problem to a big boss not in the precise and correct way,
but in a way the big boss understands. It is a lie for good."
>     
>     Original for those who reads Russian: "????????? ??????? ?????????? ??????? ????????
????? ?? ?????????, ? ???, ??? ??? ????? ???????. ??? ???? ?? ?????."

We rephrased it to better connect to Quota.


> On Jan. 7, 2016, 11:55 p.m., Neil Conway wrote:
> > docs/quota.md, line 226
> > <https://reviews.apache.org/r/42040/diff/1/?file=1186512#file1186512line226>
> >
> >     Fix this link -- probably just link to roles.md. Although we don't really call
the feature "implicit roles" in the user-facing docs (we just talk about whether a "role whitelist"
has been configured), so maybe we can just remove this.
> 
> Alexander Rukletsov wrote:
>     Though it indeed seems weird to mention random features in this user doc, I would
love to mention implicit roles somewhere here. The motivation is that it's a new (read: relatively
unknown) feature, which is highly related to quota. I would like to make sure an operator
reading this doc is aware of the feature and can use it appropriately. The best solution would
be to add a `NOTE` or a sentence and remove it in ~6 month, when implicit roles become standard.
Unfortunately, we do not support remove `TODO`s in user docs : )
> 
> Neil Conway wrote:
>     Maybe we can rephrase this to talk in terms of whether a "role whitelist" has been
configured?

Rephrased to ```However if the master is configured without an explicit
[role whitelist](roles.md) a set request can introduce new roles.```


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113358
-----------------------------------------------------------


On Jan. 8, 2016, 10:26 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 10:26 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere,
and Neil Conway.
> 
> 
> Bugs: MESOS-3877
>     https://issues.apache.org/jira/browse/MESOS-3877
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Quota Operator Documentation.
> 
> 
> Diffs
> -----
> 
>   docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535 
>   docs/quota.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42040/diff/
> 
> 
> Testing
> -------
> 
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message