mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yongqiao Wang" <yq...@cn.ibm.com>
Subject Re: Review Request 41790: Add tests for /weights endpoint.
Date Mon, 11 Jan 2016 14:38:05 GMT


> On Jan. 11, 2016, 7:55 a.m., Adam B wrote:
> > src/tests/dynamic_weights_tests.cpp, line 329
> > <https://reviews.apache.org/r/41790/diff/7/?file=1189251#file1189251line329>
> >
> >     "specified role"? Which one? You mean WEIGHTS?

Yes, I have improved the comments to more clear.


> On Jan. 11, 2016, 7:55 a.m., Adam B wrote:
> > src/tests/dynamic_weights_tests.cpp, line 148
> > <https://reviews.apache.org/r/41790/diff/7/?file=1189251#file1189251line148>
> >
> >     Why don't we have a `process::http::put()`?

I have explained it in https://reviews.apache.org/r/41789/, only want to use a general function
rather than some specific funcs.


> On Jan. 11, 2016, 7:55 a.m., Adam B wrote:
> > src/tests/dynamic_weights_tests.cpp, line 155
> > <https://reviews.apache.org/r/41790/diff/7/?file=1189251#file1189251line155>
> >
> >     What does the false do? Please comment

I will comment that in the place of httpRequest function declaration in http.hpp.


- Yongqiao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review113689
-----------------------------------------------------------


On Jan. 9, 2016, 11:38 a.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2016, 11:38 a.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4200
>     https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add tests for /weights endpoint.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am bbd0c119321fa9d11fea61b140428dd92d1258c8 
>   src/tests/dynamic_weights_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41790/diff/
> 
> 
> Testing
> -------
> 
> Make and Make check successfully!
> 
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 10 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 10 tests from DynamicWeightsTest
> [ RUN      ] DynamicWeightsTest.PutInvalidRequest
> [       OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
> [ RUN      ] DynamicWeightsTest.NegativeWeight
> [       OK ] DynamicWeightsTest.NegativeWeight (42 ms)
> [ RUN      ] DynamicWeightsTest.MissingRole
> [       OK ] DynamicWeightsTest.MissingRole (43 ms)
> [ RUN      ] DynamicWeightsTest.NonExistentRole
> [       OK ] DynamicWeightsTest.NonExistentRole (30 ms)
> [ RUN      ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [       OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (38 ms)
> [ RUN      ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
> [       OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (42 ms)
> [ RUN      ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [       OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (35 ms)
> [ RUN      ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [       OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (37 ms)
> [ RUN      ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [       OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal (44 ms)
> [ RUN      ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [       OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
> [----------] 10 tests from DynamicWeightsTest (443 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 10 tests from 1 test case ran. (452 ms total)
> [  PASSED  ] 10 tests.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message