mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 41875: Provided List constructor from std::initializer_list.
Date Mon, 11 Jan 2016 12:34:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41875/#review113743
-----------------------------------------------------------

Ship it!


As a patch it looks good, however I feel the reason we created these types inheriting from
the STL containers was to add a functionality to them (like in `hashmap` and `hashset`). But
I feel this class doesn't add anything to the default `std::list<T>` and indeed it removes
functionality since now there's no access to all the different constructors from `std::list`
and we run in the risk of leaking memory (One should not create pointers to any, `List`, `hashmap`
or `hashset`).

My preferred solution would be to delete this convenience class, and use a typedef while the
code that uses it is cleaned up, or just remove it altogether and cleanup in one pass.

- Alexander Rojas


On Jan. 8, 2016, 12:38 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41875/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 12:38 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Till Toenshoff.
> 
> 
> Bugs: MESOS-4273
>     https://issues.apache.org/jira/browse/MESOS-4273
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Provided List constructor from std::initializer_list.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/list.hpp 864d8c9498d66f14ab6fc531965c12fb397b5fe5

>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 62ad461eb228b688f1ceac16cfb003561ed5a806

>   3rdparty/libprocess/3rdparty/stout/tests/list_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41875/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X 10.10.5 and Debian 8)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message