mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 42040: Added Quota Operator Documentation.
Date Sat, 09 Jan 2016 04:09:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113601
-----------------------------------------------------------



docs/quota.md (line 20)
<https://reviews.apache.org/r/42040/#comment174355>

    s/a cluster-wide dynamic reservation/a cluster-wide dynamic reservation without resource
preemption
    
    MESOS-1607 is introducing oversubscription for reservations, so the reservation resources
can be preempted based on workload. Can we clarify it a bit here as above?



docs/quota.md (lines 33 - 34)
<https://reviews.apache.org/r/42040/#comment174356>

    But we did have plan to introduce maximal limit in MESOS-3858 , can we calarify here?



docs/quota.md (lines 63 - 64)
<https://reviews.apache.org/r/42040/#comment174358>

    s/quota set request/quota set request issued by operator



docs/quota.md (line 70)
<https://reviews.apache.org/r/42040/#comment174359>

    s/to even/even ?



docs/quota.md (line 76)
<https://reviews.apache.org/r/42040/#comment174360>

    s/scalar resources/unreserved and non-revocable scalar resourcess



docs/quota.md (line 153)
<https://reviews.apache.org/r/42040/#comment174361>

    s/quota set until/quota set?



docs/quota.md (line 175)
<https://reviews.apache.org/r/42040/#comment174362>

    Do we need to mention that the 80% is not configurable now?



docs/quota.md (line 177)
<https://reviews.apache.org/r/42040/#comment174363>

    also not configurable now



docs/quota.md (line 227)
<https://reviews.apache.org/r/42040/#comment174364>

    Add a link to implicit role?



docs/quota.md (lines 306 - 310)
<https://reviews.apache.org/r/42040/#comment174365>

    1) what about adding "update Quota" here and remove it from L189
    2) no Quota Limit but only guarantee
    
    Another point is that shall we put quota design document link here to naviagte someone
there if they want to get some design detail for Quota?


- Guangya Liu


On 一月 8, 2016, 10:26 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
> 
> (Updated 一月 8, 2016, 10:26 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere,
and Neil Conway.
> 
> 
> Bugs: MESOS-3877
>     https://issues.apache.org/jira/browse/MESOS-3877
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Quota Operator Documentation.
> 
> 
> Diffs
> -----
> 
>   docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535 
>   docs/quota.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42040/diff/
> 
> 
> Testing
> -------
> 
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message