mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 42084: Fixed header order.
Date Sat, 09 Jan 2016 00:36:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42084/#review113578
-----------------------------------------------------------


Patch looks great!

Reviews applied: [42082, 42083, 42084]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc;
./support/docker_build.sh

- Mesos ReviewBot


On Jan. 8, 2016, 8:08 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42084/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 8:08 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Rearranged headers to pull out the `#include <stout/os/...>` into a separate group.
> Pulled libprocess headers in front of stout headers in a few files.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp e93280735f1c5f66c765fcbabfd3e50b46c024e8 
>   src/linux/ns.hpp 244a811b299c29b1dcd6652bd26e861e04df3f54 
>   src/log/tool/benchmark.cpp 9cb60bd66f53e0d191d96a429bfca89d91412339 
>   src/slave/containerizer/mesos/provisioner/appc/spec.cpp 324cdfec3766da4a8e324378a6e413477fa2b5d9

>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp b74c760e90b12f5bf45b6e626e2b661f841e5a8d

>   src/slave/qos_controllers/load.cpp 52520d6220784423c09001b8bd59e090ebf787ec 
>   src/tests/containerizer/provisioner_backend_tests.cpp 25b28ef8fa5aae81e8dd0c9e33df4160dd912ce8

> 
> Diff: https://reviews.apache.org/r/42084/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message