mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jojy Varghese" <j...@mesosphere.io>
Subject Re: Review Request 41963: Logger Module: Implement ContainerLogger recovery.
Date Sat, 09 Jan 2016 00:10:11 GMT


> On Jan. 6, 2016, 7:21 p.m., Jojy Varghese wrote:
> > src/slave/containerizer/docker.cpp, line 701
> > <https://reviews.apache.org/r/41963/diff/1/?file=1183475#file1183475line701>
> >
> >     Do you need all the variables on the stack to be passed to the capture? Maybe
just executorInfo ?
> 
> Joseph Wu wrote:
>     The `[=]` should only be capturing `executorInfo`.

I believe that `[=]` directive is to `copy` all the variables on stack(and `this` to the capture.
Its recommended to avoid this style and pick what you really need in captures (intent and
not accident).


- Jojy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41963/#review113117
-----------------------------------------------------------


On Jan. 6, 2016, 2:19 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41963/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2016, 2:19 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Timothy Chen.
> 
> 
> Bugs: MESOS-4150
>     https://issues.apache.org/jira/browse/MESOS-4150
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds a call to `ContainerLogger::recover` inside each containerizer's `Containerizer::recover`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp aacf90f2cb6c08f94340936d29b2df513ac9825a 
>   src/slave/containerizer/mesos/containerizer.cpp f3c370aeb331beb6202fd30cd0278877da0b42e0

> 
> Diff: https://reviews.apache.org/r/41963/diff/
> 
> 
> Testing
> -------
> 
> make check (OSX & Centos7)
> 
> sudo bin/mesos-tests.sh --gtest_filter="*ROOT*" (Centos7)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message