mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 42030: Added example of a `defer` bug to libprocess README.
Date Fri, 08 Jan 2016 21:21:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42030/#review113534
-----------------------------------------------------------



3rdparty/libprocess/README.md (line 257)
<https://reviews.apache.org/r/42030/#comment174273>

    IMO there seems to be too much irrelevant code to make the point, can we collapse all
the unnecessary code and just keep the ones that can illustrate the problem?


- Timothy Chen


On Jan. 8, 2016, 5:01 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42030/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 5:01 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jojy Varghese, Neil Conway, and Timothy Chen.
> 
> 
> Bugs: MESOS-4207
>     https://issues.apache.org/jira/browse/MESOS-4207
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added example of a `defer` bug to libprocess README.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/README.md 6a47f6772bb7a74af368ed970af0f1c154a070e3 
> 
> Diff: https://reviews.apache.org/r/42030/diff/
> 
> 
> Testing
> -------
> 
> Viewed the markdown in a github branch: https://github.com/mesosphere/mesos/tree/defer_example/3rdparty/libprocess
> 
> Note that in addition to the inclusion of this example, further changes to the `defer`
documentation preceding the example are currently being considered: https://reviews.apache.org/r/41618/
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message