mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 41782: Logger Module: Wire up the rotating container logger module and test.
Date Fri, 08 Jan 2016 20:07:27 GMT


> On Jan. 7, 2016, 4:43 p.m., Benjamin Hindman wrote:
> > src/tests/module.cpp, line 111
> > <https://reviews.apache.org/r/41782/diff/2/?file=1181455#file1181455line111>
> >
> >     s/sandboxPath/sandboxDirectory/
> >     
> >     ?

This one points to the sandbox module (the default one).  I'll rename to `sandboxLoggerPath`.


> On Jan. 7, 2016, 4:43 p.m., Benjamin Hindman wrote:
> > src/tests/module.cpp, line 135
> > <https://reviews.apache.org/r/41782/diff/2/?file=1181455#file1181455line135>
> >
> >     Interesting that you pulled it out as a constant in the previous review, but
not here?

I was trying to stay consistent within the `module.cpp` file.


> On Jan. 7, 2016, 4:43 p.m., Benjamin Hindman wrote:
> > src/tests/module.cpp, lines 152-154
> > <https://reviews.apache.org/r/41782/diff/2/?file=1181455#file1181455line152>
> >
> >     Is this a dead flag?

This flag tells the logger module to print its `stderr` to the given file.  I added the while
debugging, and kept it because it makes sense to have an option to *not* silence the logger's
output.  

(The logger can't write errors to the log it's writing to, because the errors it reports are
due to writing to the log.)


> On Jan. 7, 2016, 4:43 p.m., Benjamin Hindman wrote:
> > src/tests/module.cpp, line 125
> > <https://reviews.apache.org/r/41782/diff/2/?file=1181455#file1181455line125>
> >
> >     I'm confused by the name of the variable `truncatingPath` ... is this a remanant
of the old code and should be `rotatingContainerLoggerPath`?

Oops.  Yes that's a remnant.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41782/#review113373
-----------------------------------------------------------


On Jan. 8, 2016, 12:06 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41782/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 12:06 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4136
>     https://issues.apache.org/jira/browse/MESOS-4136
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Creates a new binary "mesos-rotate-logger" for use by the non-default "Rotating" ContainerLogger
module.
> Adds the `RotatingContainerLogger` to the test module configuration.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am bbd0c119321fa9d11fea61b140428dd92d1258c8 
>   src/tests/module.hpp 49a9203fbbef013a47367c1912c6b642e8b6bd5c 
>   src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475 
> 
> Diff: https://reviews.apache.org/r/41782/diff/
> 
> 
> Testing
> -------
> 
> Note: Some of the files added to the makefile are created in the next review.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message