mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 41782: Logger Module: Wire up the rotating container logger module and test.
Date Fri, 08 Jan 2016 20:06:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41782/
-----------------------------------------------------------

(Updated Jan. 8, 2016, 12:06 p.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
-------

Fixed some spacing, comments, and variable names.


Bugs: MESOS-4136
    https://issues.apache.org/jira/browse/MESOS-4136


Repository: mesos


Description
-------

Creates a new binary "mesos-rotate-logger" for use by the non-default "Rotating" ContainerLogger
module.
Adds the `RotatingContainerLogger` to the test module configuration.


Diffs (updated)
-----

  src/Makefile.am bbd0c119321fa9d11fea61b140428dd92d1258c8 
  src/tests/module.hpp 49a9203fbbef013a47367c1912c6b642e8b6bd5c 
  src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475 

Diff: https://reviews.apache.org/r/41782/diff/


Testing
-------

Note: Some of the files added to the makefile are created in the next review.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message