mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <neil.con...@gmail.com>
Subject Re: Review Request 42040: Added Quota Operator Documentation.
Date Fri, 08 Jan 2016 18:08:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113496
-----------------------------------------------------------



docs/home.md (line 42)
<https://reviews.apache.org/r/42040/#comment174237>

    Typo



docs/quota.md (line 109)
<https://reviews.apache.org/r/42040/#comment174238>

    "quota of 1000 CPUs"



docs/quota.md (line 117)
<https://reviews.apache.org/r/42040/#comment174239>

    I think "non-static cluster resources" is not quite accurate here. We care about whether
the total quota exceeds the "total non-statically-reserved cluster resources", or something
like that (we need to say "static reservation", not "static cluster resource").



docs/quota.md (line 124)
<https://reviews.apache.org/r/42040/#comment174240>

    "configured quotas"



docs/quota.md (line 126)
<https://reviews.apache.org/r/42040/#comment174241>

    "The force flag".
    
    Period after "this check". I'd also rephrase slightly: "For example, this flag can be
useful when the operator would like to configure a quota that exceeds the current cluster
capacity, but they know that additional cluster resources will be added shortly."



docs/quota.md (line 170)
<https://reviews.apache.org/r/42040/#comment174242>

    "are detected"



docs/quota.md (line 175)
<https://reviews.apache.org/r/42040/#comment174243>

    "reregister"



docs/quota.md (line 176)
<https://reviews.apache.org/r/42040/#comment174244>

    add "or" at the end of the first bullet point


- Neil Conway


On Jan. 8, 2016, 10:26 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 10:26 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere,
and Neil Conway.
> 
> 
> Bugs: MESOS-3877
>     https://issues.apache.org/jira/browse/MESOS-3877
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Quota Operator Documentation.
> 
> 
> Diffs
> -----
> 
>   docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535 
>   docs/quota.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42040/diff/
> 
> 
> Testing
> -------
> 
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message