mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 41108: CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.
Date Fri, 08 Jan 2016 16:43:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41108/#review113487
-----------------------------------------------------------


Bad patch!

Reviews applied: [41096, 41185, 41108]

Failed command: ./support/apply-review.sh -n -r 41108

Error:
 2016-01-08 16:43:43 URL:https://reviews.apache.org/r/41108/diff/raw/ [4052/4052] -> "41108.patch"
[1]
error: patch failed: src/slave/cmake/FindCurl.cmake:31
error: src/slave/cmake/FindCurl.cmake: patch does not apply

- Mesos ReviewBot


On Jan. 8, 2016, 3:29 p.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41108/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 3:29 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and
Joseph Wu.
> 
> 
> Bugs: MESOS-3843
>     https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/cmake/FindCurl.cmake PRE-CREATION 
>   src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b 
> 
> Diff: https://reviews.apache.org/r/41108/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu and OSX.
> Tested if and else path of new logic added to FindCurl.cmake.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message