mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bannier" <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.
Date Fri, 08 Jan 2016 13:21:35 GMT


> On Nov. 30, 2015, 9:51 a.m., Benjamin Bannier wrote:
> > src/tests/module_tests.cpp, line 123
> > <https://reviews.apache.org/r/39781/diff/3/?file=1133386#file1133386line123>
> >
> >     None of these functions need to be (mutating!) member functions if you simply
inject `libraryDirectory`; please consider converting them to free functions, e.g. implemented
in an anon namespace in this translation unit.
> 
> James Peach wrote:
>     What exactly do you mean by "inject"? Pass the ```libraryDirectory``` as a parameter
to these free functions? Or use some Google Test or Mock injection technique?
>     
>     I'd prefer not to clutter this change with additional refactorings if that's OK.

I meant the former, but member functions are good enough too I guess. Since you changed these
from `static` functions to methods could you please at least make them `const` so it is clear
that they are not mutating instance data, though?


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39781/#review108298
-----------------------------------------------------------


On Dec. 16, 2015, 9:17 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39781/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2015, 9:17 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3725
>     https://issues.apache.org/jira/browse/MESOS-3725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update ModuleTest to not assume dynamic dlopen search.
> 
> 
> Diffs
> -----
> 
>   src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
> 
> Diff: https://reviews.apache.org/r/39781/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message