mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 42059: Update ContainerLogger to use Subprocess::IO type
Date Fri, 08 Jan 2016 09:55:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42059/#review113442
-----------------------------------------------------------


Bad patch!

Reviews applied: [42052, 42059]

Failed command: ./support/apply-review.sh -n -r 42059

Error:
 2016-01-08 09:55:31 URL:https://reviews.apache.org/r/42059/diff/raw/ [2852/2852] -> "42059.patch"
[1]
Total errors found: 0
Checking 2 files
Error: Commit message summary (the first line) must end in a period.

- Mesos ReviewBot


On Jan. 8, 2016, 2:49 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42059/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 2:49 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update ContainerLogger to use Subprocess::IO type
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/container_logger.hpp a2362070ead0afcef1e6c2ca784083ddb01ba51a 
>   src/slave/containerizer/mesos/containerizer.cpp f3c370aeb331beb6202fd30cd0278877da0b42e0

> 
> Diff: https://reviews.apache.org/r/42059/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message