mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 41816: Generated ContainerConfig in mesos containerizer.
Date Fri, 08 Jan 2016 00:05:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41816/#review113366
-----------------------------------------------------------



src/slave/containerizer/mesos/containerizer.cpp (lines 693 - 702)
<https://reviews.apache.org/r/41816/#comment173942>

    You are constructing a `containerConfig` for each isolator!
    
    I would construct `containerConfig` in `prepare` and pass it to `_prepare`.
    
    We can remove 'directory' and 'user' parameters in `_prepare` later as it's already in
`containerConfig`.


- Jie Yu


On Jan. 6, 2016, 11:40 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41816/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2016, 11:40 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4240
>     https://issues.apache.org/jira/browse/MESOS-4240
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Generated ContainerConfig in mesos containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp 89d18624b08f2c953b9fa21663aeda694d4aac12

>   src/slave/containerizer/mesos/containerizer.cpp f3c370aeb331beb6202fd30cd0278877da0b42e0

> 
> Diff: https://reviews.apache.org/r/41816/diff/
> 
> 
> Testing
> -------
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message