mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Downes" <ian.dow...@gmail.com>
Subject Re: Review Request 41726: Implement os::memory() for FreeBSD.
Date Thu, 07 Jan 2016 20:05:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41726/#review113310
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (line 626)
<https://reviews.apache.org/r/41726/#comment173840>

    Not yours, but this is getting clumsy. Can you please add a TODO to refactor this into
separate, platform specfic files.



3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (line 627)
<https://reviews.apache.org/r/41726/#comment173839>

    Please use complete words unless it's something defined externally.
    s/physMem/physicalMemory/



3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (line 633)
<https://reviews.apache.org/r/41726/#comment173849>

    Any particular reason why the OSX code above uses sysconf but it's okay to use getpagesize()
on FreeBSD? Are they equivalent...?



3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (line 648)
<https://reviews.apache.org/r/41726/#comment173842>

    s/totalBlks/totalBlocks/



3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (line 649)
<https://reviews.apache.org/r/41726/#comment173843>

    s/usedBlks/usedBlocks/



3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (line 652)
<https://reviews.apache.org/r/41726/#comment173844>

    s/mibSz/mibSize/



3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (line 657)
<https://reviews.apache.org/r/41726/#comment173850>

    Perhaps comment here that FreeBSD supports multiple swap devices and this sums across
them all.



3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (line 658)
<https://reviews.apache.org/r/41726/#comment173845>

    s/xswdSz/xswdSize/



3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (line 659)
<https://reviews.apache.org/r/41726/#comment173847>

    s/int */int* /
    Project style guide: http://mesos.apache.org/documentation/latest/c++-style-guide/
    
    s/mibDev/mibDevice/?


- Ian Downes


On Dec. 26, 2015, 3:24 p.m., David Forsythe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41726/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2015, 3:24 p.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: MESOS-4251
>     https://issues.apache.org/jira/browse/MESOS-4251
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implement os::memory() for FreeBSD.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 4cf693fb7e8c6bb3ad1920ebe90d61f0adb5dc99

> 
> Diff: https://reviews.apache.org/r/41726/diff/
> 
> 
> Testing
> -------
> 
> gmake check
> 
> 
> Thanks,
> 
> David Forsythe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message