mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride
Date Thu, 07 Jan 2016 10:15:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41600/#review113228
-----------------------------------------------------------

Ship it!



src/tests/slave_tests.cpp (line 320)
<https://reviews.apache.org/r/41600/#comment173728>

    Let's make the comment self-contained. How about:
    "`CommmandExecutor::reaped()` sleeps 1 second to avoid races, hence this test takes more
than 1 second to finish. The root cause is tracked via MESOS-4111."


- Alexander Rukletsov


On Dec. 30, 2015, 2:02 a.m., Jian Qiu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41600/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2015, 2:02 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4161
>     https://issues.apache.org/jira/browse/MESOS-4161
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since the reason for the test case being slow is MESOS-4111, we will add comment in the
test case, and remove it when MESOS-4111 is fixed.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 68d75176ce7cccafdf870fff48ac6a11089311ef 
> 
> Diff: https://reviews.apache.org/r/41600/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message