mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bannier" <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 41946: Added a `Representation` abstraction to stout.
Date Wed, 06 Jan 2016 20:00:08 GMT


> On Jan. 6, 2016, 10:51 a.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/representation.hpp, line 76
> > <https://reviews.apache.org/r/41946/diff/2/?file=1183573#file1183573line76>
> >
> >     Would it make sense to add an r-value ref qualifier here to effectively make
non-temporary `References` unusable? At least it would alleviate some cases of lifetime mismatches
between `value` and it's `Representation`.

No, it would not make sense since you use `Representation` instances as l-values. Sorry for
the noise.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41946/#review113033
-----------------------------------------------------------


On Jan. 6, 2016, 3:48 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41946/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2016, 3:48 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe

>   3rdparty/libprocess/3rdparty/stout/include/stout/representation.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41946/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message