mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 41550: [5/5] Quota Authorization: Added tests for quota removal authorization.
Date Wed, 06 Jan 2016 13:54:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41550/#review113064
-----------------------------------------------------------

Ship it!


Thanks for holding on till the end, almost there!


src/tests/master_quota_tests.cpp (line 1206)
<https://reviews.apache.org/r/41550/#comment173574>

    s/and that/while



src/tests/master_quota_tests.cpp (line 1243)
<https://reviews.apache.org/r/41550/#comment173576>

    There is no agent any more, right : )? How about
    "A request can contain any amount of resources because we set the force flag."



src/tests/master_quota_tests.cpp (line 1261)
<https://reviews.apache.org/r/41550/#comment173579>

    Same here.



src/tests/master_quota_tests.cpp (lines 1355 - 1357)
<https://reviews.apache.org/r/41550/#comment173580>

    Please prepend the block with a comment as discussed in the previous review.



src/tests/master_quota_tests.cpp (lines 1373 - 1375)
<https://reviews.apache.org/r/41550/#comment173581>

    Move the comment before the block, please


- Alexander Rukletsov


On Jan. 6, 2016, 1:15 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41550/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2016, 1:15 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
> 
> 
> Bugs: MESOS-4083
>     https://issues.apache.org/jira/browse/MESOS-4083
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota Authorization: Added tests for quota removal authorization.
> 
> 
> Diffs
> -----
> 
>   src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350 
>   src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 
> 
> Diff: https://reviews.apache.org/r/41550/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message