mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 41948: Ensured `QuotaInfo` is valid in registrar tests.
Date Wed, 06 Jan 2016 13:01:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41948/#review113060
-----------------------------------------------------------

Ship it!


Ship It!

- Joerg Schad


On Jan. 5, 2016, 11:38 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41948/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 11:38 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4058
>     https://issues.apache.org/jira/browse/MESOS-4058
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Resources in `QuotaInfo` protobuf must not specify role, hence
> remove all occurrences of `flatten()` and add explicit validation.
> 
> 
> Diffs
> -----
> 
>   src/tests/registrar_tests.cpp 6064621a001d66423f9b2dc7b749b67d9fc4bc13 
> 
> Diff: https://reviews.apache.org/r/41948/diff/
> 
> 
> Testing
> -------
> 
> `make check` on Mac OS 10.10.5
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message