mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 41597: Extending allocator interface to support dynamic weights.
Date Wed, 06 Jan 2016 10:09:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41597/#review113035
-----------------------------------------------------------


Nearly flawless, but I want to wait until I've gotten through a couple others before I commit
them all as a group.


include/mesos/master/allocator.hpp (lines 402 - 406)
<https://reviews.apache.org/r/41597/#comment173530>

    Remove the first "Updates weights." line, since that's no more helpful than the function
name. The next sentence makes a better doxygen brief description anyway, maybe reworded something
like: 
    "Updates the weight of each provided role.
    Subsequent allocation calculations will use these updated weights."



include/mesos/mesos.proto (line 1665)
<https://reviews.apache.org/r/41597/#comment173531>

    Useless comment. Please remove.



src/master/allocator/mesos/hierarchical.cpp (lines 1048 - 1051)
<https://reviews.apache.org/r/41597/#comment173539>

    Does anything rely on this behavior of erasing 1.0s from the hashmap? I know it'll (slightly)
reduce the number of bits in memory and persisted in the registry, but is there any other
reason to do this? Might be a premature optimization. Besides, the sorters still get updated
for 1.0s.
    Thoughts?


- Adam B


On Jan. 5, 2016, 6:14 p.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41597/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 6:14 p.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-3943
>     https://issues.apache.org/jira/browse/MESOS-3943
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add the interface in allocator to support updating weight
> at runtime, and the allocator is invoked to allocate the
> resources based on the updated weights later.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb33333d6 
>   include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67 
>   include/mesos/v1/mesos.proto c6c5a81eb9282d188d90fe395e1c16633a2a64cf 
>   src/master/allocator/mesos/allocator.hpp 50ef3b20f34bc6d87cbeccabcebec9a5031a6554 
>   src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08

>   src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f

>   src/master/allocator/sorter/drf/sorter.hpp 050896e8b12cd4097ccd137d5284d6b39b0f06ab

>   src/master/allocator/sorter/drf/sorter.cpp 3a442f121f3a1505513877a5c78458a4b8d0a824

>   src/master/allocator/sorter/sorter.hpp 7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 
>   src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef 
> 
> Diff: https://reviews.apache.org/r/41597/diff/
> 
> 
> Testing
> -------
> 
> Make & Make check successfully!
> 
> Test case: https://reviews.apache.org/r/41672/
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message