mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 39923: Cleaned up configuration.md.
Date Wed, 06 Jan 2016 07:17:00 GMT


> On 一月 6, 2016, 12:26 a.m., Neil Conway wrote:
> > This introduces some inconsistencies between the text in `configuration.md` and
the content of the various `flags.cpp` files (first thing I checked: "api" still appears in
`src/logging/flags.cpp` but we now use "API" in `configuration.md`; likely other instances
as well).

@Neil, please refer to https://reviews.apache.org/r/41933/ , all of the issues you mentioned
are being fixed there.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39923/#review112974
-----------------------------------------------------------


On 一月 5, 2016, 7:53 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39923/
> -----------------------------------------------------------
> 
> (Updated 一月 5, 2016, 7:53 p.m.)
> 
> 
> Review request for mesos, Jojy Varghese, Joris Van Remoortere, Kapil Arya, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Edited configuration.md for style and consistency. Made consistent use of <code></code>
for commands, flags, and flag values. Edited the libprocess flags for consistency and proper
use of `=DIR` or `[=DIR]` depending on whether or not the directory is an optional parameter.
Note that the libprocess `--with-*` flags have two different descriptions depending upon whether
or not the library is bundled with Mesos.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md a33e802a3ff1246d25f52b15da7905c5b22e339d 
> 
> Diff: https://reviews.apache.org/r/39923/diff/
> 
> 
> Testing
> -------
> 
> Viewed with the mesos website container (https://github.com/mesosphere/mesos-website-container).
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message