mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 41454: Added initial draft of executor HTTP API user doc.
Date Wed, 06 Jan 2016 00:43:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41454/#review112961
-----------------------------------------------------------



docs/executor-http-api.md (line 33)
<https://reviews.apache.org/r/41454/#comment173447>

    Can you replace this with:
    
    * **Unacknowledged Tasks**:
    
    The executor is expected to maintain a list of tasks that have not been acknowledged by
the agent. A task is considered acknowledged if atleast one of the status updates for this
task is acknowledged by the slave.



docs/executor-http-api.md (line 334)
<https://reviews.apache.org/r/41454/#comment173452>

    lets call this
    
    MESOS_RECOVERY_TIMEOUT like what we currently have in the driver. I think it makes it
obvious that this is the same as --recovery_timeout set on the agent.



docs/executor-http-api.md (line 335)
<https://reviews.apache.org/r/41454/#comment173453>

    Lets keep the MESOS prefix like you did for all the above. Sorry for the run around.
    
    MESOS_SUBSCRIPTION_BACKOFF_MAX


- Vinod Kone


On Jan. 5, 2016, 9:28 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41454/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 9:28 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4177
>     https://issues.apache.org/jira/browse/MESOS-4177
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is an initial draft for the user doc of Executor HTTP API. Some details might change
due to the pending executor library review chain: https://reviews.apache.org/r/41275
> 
> 
> Diffs
> -----
> 
>   docs/executor-http-api.md PRE-CREATION 
>   docs/home.md d929838206817a6c49cc2343b4de82fa085da682 
> 
> Diff: https://reviews.apache.org/r/41454/diff/
> 
> 
> Testing
> -------
> 
> https://gist.github.com/hatred/d35fdaa667203bf34a78
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message