mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mp...@apache.org>
Subject Re: Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.
Date Tue, 05 Jan 2016 23:41:40 GMT


> On Jan. 3, 2016, 11:55 p.m., Benjamin Hindman wrote:
> > I assume you've gotten all of them?

I've gotten all of the ones in `Future`. I think as they work through rest of the codebase,
there may be more contexts in which this comes up.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41459/#review112481
-----------------------------------------------------------


On Dec. 28, 2015, 3:42 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41459/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2015, 3:42 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4221
>     https://issues.apache.org/jira/browse/MESOS-4221
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> VS 2015 won't support C++14 `std::function` SFINAE until Update 2, so converting `_Deferred`
to `std::function` must be done by explicitly calling `_Deferred`'s conversion function.
> 
> Follow-up from [r40114](https://reviews.apache.org/r/40114/).
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp c9146e3a3ccf09dd37c5a8ac7000fbe84f3c710c

> 
> Diff: https://reviews.apache.org/r/41459/diff/
> 
> 
> Testing
> -------
> 
> `make check` on OS X, compiled on Windows.
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message