mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 41550: [5/5] Quota Authorization: Added tests for quota removal authorization.
Date Tue, 05 Jan 2016 19:03:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41550/#review112893
-----------------------------------------------------------



src/tests/authorization_tests.cpp (line 765)
<https://reviews.apache.org/r/41550/#comment173370>

    As always, please describe the test in a few words  within a leading comment.



src/tests/authorization_tests.cpp (lines 826 - 828)
<https://reviews.apache.org/r/41550/#comment173371>

    Very verbose but to me also very helpful comment.



src/tests/master_quota_tests.cpp (line 1119)
<https://reviews.apache.org/r/41550/#comment173373>

    Blank line?



src/tests/master_quota_tests.cpp (line 1122)
<https://reviews.apache.org/r/41550/#comment173374>

    Blank line?


- Till Toenshoff


On Jan. 5, 2016, 3:13 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41550/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 3:13 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
> 
> 
> Bugs: MESOS-4083
>     https://issues.apache.org/jira/browse/MESOS-4083
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota Authorization: Added tests for quota removal authorization.
> 
> 
> Diffs
> -----
> 
>   src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350 
>   src/tests/master_quota_tests.cpp 2f1bc3ae6a370e466f7cea9b597f51d7eccb1b33 
> 
> Diff: https://reviews.apache.org/r/41550/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message