mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 41550: [5/5] Quota Authorization: Added tests for quota removal authorization.
Date Tue, 05 Jan 2016 19:02:46 GMT


> On Jan. 5, 2016, 12:59 p.m., Alexander Rukletsov wrote:
> > src/tests/master_quota_tests.cpp, line 1380
> > <https://reviews.apache.org/r/41550/diff/2/?file=1181807#file1181807line1380>
> >
> >     Again, I think this one can be merged with `AuthorizedQuotaRemoveRequest` (you
can use scopes for clarity). After a second thought I think we can go even further and merge
`UnauthorizedQuotaSetRequest` into those as well. What do you think?
> 
> Jan Schlicht wrote:
>     In contrast to the other suggestions, I'm not sure about this one: To merge this
test with `AuthorizedQuotaRemoveRequest` or `AuthorizedQuotasSetRequest`, both tests would
need a much more sophisticated ACL to be able to do this, because the ACLs can't be changed
after the master has been started. Currently we would need another credential, similar to
`DEFAULT_CREDENTIAL`, to support this. In my opinion this would be too much changes needed.

I think having sophisticated ACL is not an issue, it may even be good for testing purposes
: ). I agree with your second argument though. Luckily, Greg Mann recently posted a review
which solves exactly this problem: https://reviews.apache.org/r/41934/. I'm okay with committing
this as is right now, but I would love to see this revisited once r/41934 lands.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41550/#review112840
-----------------------------------------------------------


On Jan. 5, 2016, 3:13 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41550/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 3:13 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
> 
> 
> Bugs: MESOS-4083
>     https://issues.apache.org/jira/browse/MESOS-4083
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota Authorization: Added tests for quota removal authorization.
> 
> 
> Diffs
> -----
> 
>   src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350 
>   src/tests/master_quota_tests.cpp 2f1bc3ae6a370e466f7cea9b597f51d7eccb1b33 
> 
> Diff: https://reviews.apache.org/r/41550/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message