> On Jan. 5, 2016, 8:16 a.m., Adam B wrote:
> > Looks good. My biggest question is whether `class Roles` needs to exist, or whether
we can just use freestanding `roles::validate()` functions.
Thank you very much. I use vector<string> instead. Could you help review again?
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/#review112788
-----------------------------------------------------------
On Jan. 5, 2016, 3:19 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35711/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 3:19 p.m.)
>
>
> Review request for mesos, Adam B, Jie Yu, and Michael Park.
>
>
> Bugs: MESOS-2210
> https://issues.apache.org/jira/browse/MESOS-2210
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Disallow special characters in role name.
>
>
> Diffs
> -----
>
> docs/roles.md af1adad7ec8122fd10f7de44848014b850416bcd
> include/mesos/roles.hpp PRE-CREATION
> src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0
> src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817
> src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4
> src/common/roles.cpp PRE-CREATION
> src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011
> src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320
> src/tests/role_tests.cpp 91a6d27158a21ae11dd310dd1f55922dc147e6f3
>
> Diff: https://reviews.apache.org/r/35711/diff/
>
>
> Testing
> -------
>
> make -j8 check
>
>
> Thanks,
>
> haosdent huang
>
>
|