mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 41593: Added `jsonify` function to stout.
Date Tue, 05 Jan 2016 14:56:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41593/#review112845
-----------------------------------------------------------


Pretty clever code, it would be nice if some of the techniques were at least explained in
a blog post with a link in the code. I'm mostly concerend about the use of C++17 functions
(`std::rank`). Does that mean we are pumping the minimum required version for the compiler?
otherwise, could we investigate the compiler and/or stdlib support?


3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp (lines 368 - 371)
<https://reviews.apache.org/r/41593/#comment173330>

    I have a couple of questions here:
    
    1. Why do you use a `U&`.
    2. Can you add a comment on how this work, it is definitely not clear for even an intermediate
level C++ programmer.



3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp (line 561)
<https://reviews.apache.org/r/41593/#comment173332>

    Doesn't the `std::result_of` has the same problem in windows as when used in `Future`?


- Alexander Rojas


On Jan. 5, 2016, 11:20 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41593/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 11:20 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 5ab7bc4966fe32eaddd573a4dbfd997f98b5d481

>   3rdparty/libprocess/3rdparty/stout/README.md a2a3dc6120b10c8fe82088b9f0ebecfa5642f945

>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe

>   3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 98ea47794b3a7c99b3cbd2418ba6e36eb5951259

>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 62ad461eb228b688f1ceac16cfb003561ed5a806

>   3rdparty/libprocess/3rdparty/stout/tests/jsonify_tests.cpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp bf2a2b8a9f67c6a4cf66b156b9c14fae015a8af0

> 
> Diff: https://reviews.apache.org/r/41593/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message