mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 39043: Added support for HTTP Authentication in Mesos.
Date Tue, 05 Jan 2016 12:57:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/#review112830
-----------------------------------------------------------



src/master/http.cpp (line 1661)
<https://reviews.apache.org/r/39043/#comment173316>

    I suggest this deleting this rather redundant and slightly misplaced comment. Here, the
code readability improves in its absense, IMHO.



src/master/master.cpp (line 503)
<https://reviews.apache.org/r/39043/#comment173321>

    Please correct the spelling mistakes in this comment.



src/master/master.cpp (line 528)
<https://reviews.apache.org/r/39043/#comment173328>

    Isn't there a version of BasicAuthenticatorFactory::create() that takes credentials instead
of parameters? Then we can omit the packaging up here.



src/master/master.cpp (line 561)
<https://reviews.apache.org/r/39043/#comment173326>

    This somment is rather cryptic. Ownership of what? Why? How?



src/tests/mesos.cpp (line 430)
<https://reviews.apache.org/r/39043/#comment173314>

    Singular, plural? "s" behind "lifetime", not "Authenticator"?
    
    What mesos process? "the Mesos master process"?



src/tests/mesos.cpp (line 431)
<https://reviews.apache.org/r/39043/#comment173315>

    s/c/C


- Bernd Mathiske


On Jan. 5, 2016, 3:18 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39043/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 3:18 a.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, Jan Schlicht, and Till
Toenshoff.
> 
> 
> Bugs: MESOS-3756
>     https://issues.apache.org/jira/browse/MESOS-3756
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> 1. Adds a flag to load an HTTP Authenticator module from the flags.
> 2. If provided, uses the credentials file to initialize the default HTTP Authenticator.
> 3. Updates the existing endpoints which implement their own basic HTTP authenticator
with the libprocess one.
> 4. Updates one test which expected the wrong results since now credentials are checked
before the body of the request.
> 
> 
> Diffs
> -----
> 
>   src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840 
>   src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4 
>   src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 
>   src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 
>   src/master/http.cpp deb0c8f9852dc0eec1e8c0ff35c684f982e8b110 
>   src/master/master.hpp 1cc5531de70bdc0bdce9835c4930dc774406fac9 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
>   src/master/quota_handler.cpp 1d84ef5767b3cb7cf870dd184aa2d9f030919498 
>   src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a 
> 
> Diff: https://reviews.apache.org/r/39043/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message