mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jan Schlicht" <...@mesosphere.io>
Subject Re: Review Request 40966: Corrected termination of Docker containers.
Date Tue, 05 Jan 2016 12:34:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40966/
-----------------------------------------------------------

(Updated Jan. 5, 2016, 1:34 p.m.)


Review request for mesos, Greg Mann, haosdent huang, Jojy Varghese, Till Toenshoff, and Timothy
Chen.


Changes
-------

Rebased (added `ContainerLogger` due to changed `MockDockerContainerizer` constructor)


Bugs: MESOS-4025
    https://issues.apache.org/jira/browse/MESOS-4025


Repository: mesos


Description
-------

Tests cases have to wait until a container has been terminated by the
DockerContainerizer. Otherwise there could be artifacts (e.g. locked cgroups)
that can affect later test cases (see MESOS-4025, where cgroups couldn't be
removed).


Diffs (updated)
-----

  src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566 

Diff: https://reviews.apache.org/r/40966/diff/


Testing
-------

make check
sudo ./bin/mesos-tests.sh --gtest_repeat=50 --gtest_filter="HealthCheckTest.ROOT_DOCKER_*:SlaveRecoveryTest*GCExecutor"


Thanks,

Jan Schlicht


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message