mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 41881: Provided constexpr Duration min and max values.
Date Tue, 05 Jan 2016 03:40:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41881/#review112754
-----------------------------------------------------------


Patch looks great!

Reviews applied: [41881]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc;
./support/docker_build.sh

- Mesos ReviewBot


On Jan. 4, 2016, 6:43 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41881/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 6:43 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Till Toenshoff, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4277
>     https://issues.apache.org/jira/browse/MESOS-4277
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> For that we need to provide a constexpr constructor for Nanoseconds at
> least; make all constructors of Duration types constexpr if possible.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp dc610e697032f0d5d9c7a6524aeb34984041dec7

> 
> Diff: https://reviews.apache.org/r/41881/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X 10.10.5).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message