mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 39834: Made `path_tests.cpp` standalone.
Date Mon, 04 Jan 2016 22:34:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39834/#review112670
-----------------------------------------------------------


Bad patch!

Reviews applied: [39621, 39620, 39622, 39623, 39019, 39803]

Failed command: ./support/apply-review.sh -n -r 39803

Error:
 2016-01-04 22:34:07 URL:https://reviews.apache.org/r/39803/diff/raw/ [20944/20944] ->
"39803.patch" [1]
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp:118:  Lines
should be <= 80 characters long  [whitespace/line_length] [2]
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp:68:  Lines should
be <= 80 characters long  [whitespace/line_length] [2]
Total errors found: 1
Checking 4 files

- Mesos ReviewBot


On Jan. 4, 2016, 7:10 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39834/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 7:10 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere,
and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made `path_tests.cpp` standalone.
> 
> NB, more of these tests will move when `Hopcroft` is done with his `os::symlink` changeset.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 821dbb185f09e2f279d95fd354ce2168cddf1bac

> 
> Diff: https://reviews.apache.org/r/39834/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message