mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 41870: [stout] Added ref-qualifiers to Option::get().
Date Mon, 04 Jan 2016 22:08:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41870/#review112658
-----------------------------------------------------------


Waiting on dev-list e-mail regarding support for gcc 4.8.1 and above, as this is not supported
in 4.8.0.

- Joris Van Remoortere


On Jan. 4, 2016, 7:09 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41870/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 7:09 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This trivial change adds ref-qualifiers introduced in C++11 to Option::get(). This is
in sync with what boost/folly `optional` already have.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp b58350b312c1969aa86ec679e95af0f97846c141

> 
> Diff: https://reviews.apache.org/r/41870/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Verified this enables operations like the following to incur a move instead of a copy:
> 
> ```
> Option<T> create();
> T t = create().get();
> ```
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message