mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhitao Li" <zhitaoli...@gmail.com>
Subject Review Request 41892: DockerContinerizer infers hostPath for persistent volumes.
Date Mon, 04 Jan 2016 21:15:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41892/
-----------------------------------------------------------

Review request for mesos, haosdent huang and Jie Yu.


Bugs: MESOS-3413
    https://issues.apache.org/jira/browse/MESOS-3413


Repository: mesos


Description
-------

This diff makes DockerContainerizer infers hostPath for persistent volumes from resources
passed-in.

This allows current DockerContainerizer to use persistent volumes w/o hard code slave's work_dir.
I also checked that the inferred directory actually exists to avoid framework messing up role
or persistent id.

Note that some validation on the resource part should be done before we start the container,
which seems to belong to slave.


Diffs
-----

  src/docker/docker.hpp dde2b29deda7e40929e0169935a5bafdd43136b1 
  src/docker/docker.cpp e93280735f1c5f66c765fcbabfd3e50b46c024e8 
  src/docker/executor.hpp abbc419533ab40312e917931a2fc2ce78b38da41 
  src/docker/executor.cpp 7512d07de6c8324340e6b5f3e5162ef00efc47fc 
  src/slave/containerizer/docker.cpp aacf90f2cb6c08f94340936d29b2df513ac9825a 
  src/tests/containerizer/docker_containerizer_tests.cpp cb58b7183c36d96b9ac4803c63980c278a50c97b

  src/tests/containerizer/docker_tests.cpp 83eceacaddc38d0ccfc42e65e700a09406d8df36 
  src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249 
  src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a 

Diff: https://reviews.apache.org/r/41892/diff/


Testing
-------

New unit test.


Thanks,

Zhitao Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message