mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.
Date Mon, 04 Jan 2016 11:49:47 GMT


> On Nov. 4, 2015, 6:08 p.m., Michael Hopcroft wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp, line 154
> > <https://reviews.apache.org/r/39803/diff/2/?file=1113684#file1113684line154>
> >
> >     Have you checked all of the return types to ensure they are what you think they
are? Windows has a lot of #ifdefs for these types and it is possible that an unexpected cast
could cause problems. I would look at the definition of each field type in _stat and add static
asserts where necessary to ensure the type is what you think it is. Another possibility is
that your functions return types like "unsigned int" and perform the casting from s.st_dev
directly in your function.

Yes, I've verified them. I'll have to look into this static assert thing though. It had not
occurred to me to do this.


> On Nov. 4, 2015, 6:08 p.m., Michael Hopcroft wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp, line 166
> > <https://reviews.apache.org/r/39803/diff/2/?file=1113684#file1113684line166>
> >
> >     According to the Windows documentation, "The inode, and therefore st_ino, has
no meaning in the FAT, HPFS, or NTFS file systems." Will this be a problem?
> >     
> >     https://msdn.microsoft.com/en-us/library/14h5k7ff.aspx

This should not impact the Windows codebase, no. It is used only in one place, the pid isolator,
and we don't need that.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39803/#review105083
-----------------------------------------------------------


On Jan. 4, 2016, 11:46 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39803/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 11:46 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere,
and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Implemented stout/os/stat.hpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe

>   3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp PRE-CREATION

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp 5b38b9af654d7d1c574f0cc573083b66693ced1d

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd

> 
> Diff: https://reviews.apache.org/r/39803/diff/
> 
> 
> Testing
> -------
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message