mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 41857: [WIP][MESOS-3892] get evictable executors
Date Mon, 04 Jan 2016 08:21:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41857/#review112516
-----------------------------------------------------------



src/slave/slave.hpp (lines 374 - 376)
<https://reviews.apache.org/r/41857/#comment172983>

    period to the end.



src/slave/slave.cpp (line 3954)
<https://reviews.apache.org/r/41857/#comment172987>

    Here should be requested.stateless().reserved()



src/slave/slave.cpp (line 3974)
<https://reviews.apache.org/r/41857/#comment172988>

    I think that we can ignore the eviciting executors here, just check if the available minus
occupied does not contain allocationSlack, reutn error. The revocable tasks can be treated
as low priority and no need make it pending for resources, comments?



src/slave/slave.cpp (lines 3978 - 3983)
<https://reviews.apache.org/r/41857/#comment172989>

    Why evict executor for revocable tasks?



src/slave/slave.cpp (line 4008)
<https://reviews.apache.org/r/41857/#comment172991>

    What about using following to get evictable executors?
    
    if (availabe-occupied+evicting).contains(reserved)
       wait for executor terminated future 
    else:
       evcit some executors


- Guangya Liu


On Jan. 3, 2016, 2:23 a.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41857/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2016, 2:23 a.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3892
>     https://issues.apache.org/jira/browse/MESOS-3892
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> get evictable executors
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 
> 
> Diff: https://reviews.apache.org/r/41857/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message