mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 41586: Partially enforced commit message guidelines with a hook.
Date Mon, 04 Jan 2016 07:59:23 GMT


> On Dec. 24, 2015, 2:27 a.m., Adam B wrote:
> > support/hooks/commit-msg, lines 6-7
> > <https://reviews.apache.org/r/41586/diff/1/?file=1172701#file1172701line6>
> >
> >     # To enable this hook, do this from the root of the repo:
> >     #
> >     # $ ln -s ../../support/hooks/commit-message .git/hooks/commit-message
> 
> Artem Harutyunyan wrote:
>     In our case it's done automatically by the bootstrap script. It's part of this same
commit. Added a clarifying comment.

Seems like the other two hooks are enabled by bootstrap as well. Let's keep it consistent.
I'll update this one to more closely resemble the others, "To enable this hook, run `bootstrap`
or do this..."


> On Dec. 24, 2015, 2:27 a.m., Adam B wrote:
> > support/hooks/commit-msg, line 4
> > <https://reviews.apache.org/r/41586/diff/1/?file=1172701#file1172701line4>
> >
> >     "should"? Are you unsure if it will?
> 
> Artem Harutyunyan wrote:
>     I believe that the `if it wants to stop the commit` part of the sentence makes it
pretty explicit, no? Again, this comment is part of the template hook file. If you have a
suggestion on how to rewrite it I'll gladly follow it :-).

Edited to "The hook exits with non-zero status after..."


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41586/#review111839
-----------------------------------------------------------


On Dec. 30, 2015, 11:28 a.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41586/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2015, 11:28 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Partially enforced commit message guidelines with a hook.
> 
> 
> Diffs
> -----
> 
>   bootstrap 89d986fd95dc16bbb79623ef92e3b14a2e7009f9 
>   support/hooks/commit-msg PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41586/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message