mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 41855: [WIP][MESOS-3982] Trace pending executors
Date Mon, 04 Jan 2016 07:26:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41855/#review112509
-----------------------------------------------------------



src/slave/slave.hpp (line 795)
<https://reviews.apache.org/r/41855/#comment172971>

    Add a blank line before 
    hashmap<ExecutorID, ExecutorInfo> pendingExecutors;



src/slave/slave.cpp (line 5240)
<https://reviews.apache.org/r/41855/#comment172974>

    It is better add this comment after `Slave::checkAvailabeResource` was added.
    
    s/;/.


- Guangya Liu


On Jan. 3, 2016, 1:56 a.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41855/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2016, 1:56 a.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3982
>     https://issues.apache.org/jira/browse/MESOS-3982
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Trace the executor that are not launched; after launching, it's removed from pendingExecutor
list.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 
> 
> Diff: https://reviews.apache.org/r/41855/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message