mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.
Date Mon, 04 Jan 2016 07:04:03 GMT


> On Dec. 11, 2015, 7:47 p.m., Joseph Wu wrote:
> > src/common/resources.cpp, lines 1380-1382
> > <https://reviews.apache.org/r/40375/diff/8/?file=1159654#file1159654line1380>
> >
> >     I'm not sure if this is necessary.  
> >     
> >     To be as backwards compatible as possible, the `USAGE_SLACK` type would output
as `{REV}`.  But is there any parsing of stringified `Resources` between the master and agent?
> 
> Klaus Ma wrote:
>     The communitcation between master and agent should be fine, we passed all UT with
the patch.
>     Just not sure whether the 3rd part application will pass endpoint's output. If we
updated it, we should drop an email to dev@; any comments?

The {REV}, {ALLOCATION_SLACK}, {USAGE_SLACK} are only for tracing some logs in master and
agent, end user need to use API to set different revocable types. So I think that we can keep
this as it is for now. Thanks.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review109993
-----------------------------------------------------------


On Dec. 12, 2015, 3:19 p.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2015, 3:19 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3888
>     https://issues.apache.org/jira/browse/MESOS-3888
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-3888: We need to distinguish revocable resource for usage slack and allocation
slack.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 8ca2130 
>   include/mesos/v1/mesos.proto 8f357b0 
>   src/common/resources.cpp 5a79817 
>   src/tests/resources_tests.cpp ce47bac 
>   src/v1/resources.cpp d300842 
> 
> Diff: https://reviews.apache.org/r/40375/diff/
> 
> 
> Testing
> -------
> 
> make && make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message